Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping up minimum version of go to a supported version #3046

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

iwankgb
Copy link
Collaborator

@iwankgb iwankgb commented Jan 9, 2022

Hey, long time, no see.

This is an RFC to some extent: go 1.13 is not supported since 1.15 (August 2020). Should we still indicated 1.13 as minimum required golang version? I don't think so:

  • there has been bunch of CVEs published since 08/2020
  • I think it's good idea to force users to use supported compiler version

@bobbypage, what do you think? Kubernetes requires 1.16 since March 2021.

@iwankgb
Copy link
Collaborator Author

iwankgb commented Jan 9, 2022

/test pull-cadvisor-e2e

@bobbypage
Copy link
Collaborator

LGTM, thanks!

@bobbypage bobbypage merged commit 96296fe into google:master Jan 10, 2022
@iwankgb iwankgb deleted the bump_minimum_golang_version branch January 10, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants